chore!: bump typescript to 5.7.3 #5137
Conversation
|
/nucleus test |
|
/nucleus test |
There was a problem hiding this comment.
Might need to play some config tetris with eslint / eslint-typescript / typescript , but the CI error below should be fixed now.
$ eslint . --cache
/home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-code.ts
0:0 error Parsing error: /home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-code.ts was included by allowDefaultProject but also was found in the project service. Consider removing it from allowDefaultProject
/home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-type.ts
0:0 error Parsing error: /home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-type.ts was included by allowDefaultProject but also was found in the project service. Consider removing it from allowDefaultProject
/home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/setup-test.ts
0:0 error Parsing error: /home/runner/work/lwc/lwc/packages/@lwc/module-resolver/scripts/test/setup-test.ts was included by allowDefaultProject but also was found in the project service. Consider removing it from allowDefaultProject
| allowDefaultProject: [ | ||
| // I'm not sure why these files aren't picked up... :\ | ||
| 'packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-code.ts', | ||
| 'packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-type.ts', | ||
| 'packages/@lwc/module-resolver/scripts/test/setup-test.ts', | ||
| ], |
There was a problem hiding this comment.
Now they're picked up and we're also not sure why! 😄
There was a problem hiding this comment.
Probably this: https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#searching-ancestor-configuration-files-for-project-ownership
It only affects whatever interfaces with tsserverlibrary's ProjectService (eg: typescript-eslint). Doesn't affect output.
|
|
||
| parserOptions: { | ||
| projectService: true, | ||
| }, |
There was a problem hiding this comment.
Third time's a charm.
|
/nucleus test |
|
One of the nucleus failures (LWR) seems to be a type error. Seems plausibly related to this change, but also maybe not? I can investigate next week. |
|
Assuming the nucleus test actually caught downstream breakages, it would be nice to have a summary here. Some might be fixed by more explicit annotation, the others documented here for inclusion in the changelog. |
Details
Since bumping typescript may cause type declarations to change even in minor versions, this PR can only be merged with the next lwc major release.
In this repo, I couldn't observe any new errors. It would be interesting to see if running this in CI would surface any downstream breakages that can be listed here and perhaps avoided.
For reference, here are the behavioral changes in versions since current (5.4): 5.5, 5.6, 5.7.
If typescript 5.8 is released before this is merged, it may be worth updating this PR to use that version.
It fixes a possible regression, although unlikely to affect anything here: microsoft/TypeScript#60506(nevermind, this fix was backported to 5.7)Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item